[buddypress-trac] [BuddyPress Trac] #7639: Reopening #4706: Infinite Redirect Loop when BP_GROUPS_DEFAULT_EXTENSION is changed on Private groups

[buddypress-trac]

#7639: Reopening #4706: Infinite Redirect Loop when BP_GROUPS_DEFAULT_EXTENSION is
changed on Private groups
-------------------------------------------+-----------------------------
 Reporter:  pareshradadiya                 |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Future Release
Component:  Groups                         |     Version:  2.9.2
 Severity:  normal                         |  Resolution:
 Keywords:  needs-patch reporter-feedback  |
-------------------------------------------+-----------------------------
Changes (by DJPaul):

 * milestone:  Under Consideration => Future Release


Comment:

 The redirect is being triggered on
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/bp-core-
 buddybar.php?annotate=blame#L676 (that branch of that conditional).
 `$subnav_item` item there is:

 {{{
 array(11) {
   ["slug"]=>
   string(7) "members"
   ["parent_slug"]=>
   string(2) "t3"
   ["user_has_access"]=>
   bool(false)
   ["no_access_url"]=>
   string(30) "http://bpcore.local/groups/t3/"
   ["site_admin_only"]=>
   bool(false)
   ["screen_function"]=>
   &string(27) "groups_screen_group_members"
   ["name"]=>
   string(22) "Members 1"
   ["link"]=>
   string(30) "http://bpcore.local/groups/t3/"
   ["css_id"]=>
   string(7) "members"
   ["position"]=>
   int(60)
   ["show_in_admin_bar"]=>
   bool(false)
 }
 }}}

 ...which is the navigation item set here:
 https://buddypress.trac.wordpress.org/browser/trunk/src/bp-groups/classes
 /class-bp-groups-component.php#L576 ("Only add the members subnav if it's
 not the home's nav.") -- that makes sense, but I'm lost trying to
 understand what should be happening where...

 It's something to do with the user not allowed to read a Private group's
 "members" page, but I'm not sure where the redirect should be fixed or
 how.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7639#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac