[buddypress-trac] [BuddyPress Trac] #7096: Messages: member page messages are queried for the loggedin user

buddypress-trac noreply at wordpress.org
Tue Jun 6 16:40:23 UTC 2017


#7096: Messages: member page messages are queried for the loggedin user
--------------------------+----------------------------------
 Reporter:  Offereins     |       Owner:  dcavins
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  Under Consideration
Component:  Messages      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+----------------------------------

Comment (by r-a-y):

 Nice catch, @dcavins, about the return value of
 `messages_check_thread_access()`.  Although, it is quite possible that
 someone (ugh!) could be using this to grab the message ID, I would
 personally change the return value to a boolean.

 Internally, we use the function to check for a falsey value only.
 However, since we like to backpat all the time, I would ask a lead dev
 what they think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7096#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list