[buddypress-trac] [BuddyPress Trac] #7634: PHP 7.2 compatibility

[buddypress-trac]

#7634: PHP 7.2 compatibility
--------------------------+-------------------------
 Reporter:  netweb        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.0
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:  needs-patch
--------------------------+-------------------------
 Following [11753] the PHP 7.2, 6 tests in the PHP 7.2 Travis CIjobs are
 failing:

 e.g. https://travis-ci.org/buddypress/BuddyPress/jobs/309634382:

 {{{
 There were 6 errors:


 1) BP_Tests_Media_Extractor::test_extract_media_from_a_wp_post

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:3259

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:2102

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-actions.php:704

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:286

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:310

 /tmp/wordpress/src/wp-includes/plugin.php:453

 /tmp/wordpress/src/wp-includes/post.php:4038

 /tmp/wordpress/src/wp-includes/post.php:3498

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-post.php:27

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-thing.php:32

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/core/class-bp-media-
 extractor.php:152


 2)
 BP_Tests_Media_Extractor::test_extract_images_from_content_with_galleries_variant_no_ids

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:3259

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:2102

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-actions.php:704

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:286

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:310

 /tmp/wordpress/src/wp-includes/plugin.php:453

 /tmp/wordpress/src/wp-includes/post.php:4038

 /tmp/wordpress/src/wp-includes/post.php:3498

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-post.php:27

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-thing.php:32

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/core/class-bp-media-
 extractor.php:303


 3)
 BP_Tests_Media_Extractor::test_extract_no_images_from_content_with_invalid_galleries_variant_no_ids

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:3259

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:2102

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-actions.php:704

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:286

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:310

 /tmp/wordpress/src/wp-includes/plugin.php:453

 /tmp/wordpress/src/wp-includes/post.php:4038

 /tmp/wordpress/src/wp-includes/post.php:3498

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-post.php:27

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-thing.php:32

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/core/class-bp-media-
 extractor.php:344


 4)
 BP_Tests_Media_Extractor::test_extract_no_images_from_content_with_featured_image

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:3259

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:2102

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-actions.php:704

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:286

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:310

 /tmp/wordpress/src/wp-includes/plugin.php:453

 /tmp/wordpress/src/wp-includes/post.php:4038

 /tmp/wordpress/src/wp-includes/post.php:3498

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-post.php:27

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-thing.php:32

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/core/class-bp-media-
 extractor.php:371


 5)
 BP_Tests_Media_Extractor::test_extract_images_from_content_without_featured_image

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:3259

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-functions.php:2102

 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-activity/bp-
 activity-actions.php:704

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:286

 /tmp/wordpress/src/wp-includes/class-wp-hook.php:310

 /tmp/wordpress/src/wp-includes/plugin.php:453

 /tmp/wordpress/src/wp-includes/post.php:4038

 /tmp/wordpress/src/wp-includes/post.php:3498

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-post.php:27

 /tmp/wordpress/tests/phpunit/includes/factory/class-wp-unittest-factory-
 for-thing.php:32

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/core/class-bp-media-
 extractor.php:392


 6) BP_Tests_Members_Functions::test_bp_last_activity_migrate

 count(): Parameter must be an array or an object that implements Countable


 /tmp/wordpress/src/wp-includes/meta.php:194

 /tmp/wordpress/src/wp-includes/user.php:825

 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/members/functions.php:364

 }}}

 Related: #WP40109

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7634>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac