[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

[buddypress-trac]

#6772: BuddyPress Embeds for activity, user profiles, groups
------------------------------------+------------------
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.6
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------

Comment (by imath):

 @r-a-y fantastic work. I think we're about to touchdown!

 I've found an issue though:
 > In order for links to work while using <iframe sandbox>, I had to add
 the sandbox="allow-top-navigation" attribute. The other gotcha here is in
 order for links to be clickable, links must use top.location.href. (See
 bp_activity_embed_excerpt_onclick_location_filter().) If we'd rather links
 open in a new window, let me know

 When i click on the play svg button, this is what i get:

 [[Image(https://cldup.com/HgakRZVixa.png)]]

 The link won't open :( I was thinking what about using the activity
 permalink instead ?


 Then i have a question, the width for the embed is depending on the image
 width ? Because i find it weird to have this kind of layout
 [[Image(https://cldup.com/i6VDFGy0LR.png)]]

 and this kind of layout for youtube:
 [[Image(https://cldup.com/B6Y61bq1jt.png)]]

 What about centering it ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:41>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac