[buddypress-trac] [BuddyPress Trac] #4824: Autocomplete

buddypress-trac noreply at wordpress.org
Thu May 19 03:10:50 UTC 2016


#4824: Autocomplete
-----------------------------------+-----------------------
 Reporter:  stefwilliams           |       Owner:
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  2.6
Component:  Component - Messaging  |     Version:  2.5.0
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:   => has-patch 2nd-opinion
 * milestone:   => 2.6


Comment:

 @pareshradadiya @mlwilkerson Thanks for reviving this issue. The root
 problem is that we are loading our own library that registers itself as
 `jQuery.fn.autocomplete`, and it's different from the jQuery UI library
 loaded by `wp_editor()`. The only way I can think of to fix this problem
 is to change the name of our library. In [attachment:4824.diff], I've made
 it `jQuery.fn.autocompletebp`. It's ugly, but it resolves the conflict.

 The only potential for breakage here is if someone was intentionally
 trying to do something custom using our autocomplete scripts on their
 page. I have a feeling this is very unlikely, and I would much rather fix
 the problem with `wp_editor()` than try to maintain this weird bit of
 backward compatibility. Does anyone disagree?

 This would go away if we used something less insane for our autocomplete.
 See #4580.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4824#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list