[buddypress-trac] [BuddyPress Trac] #7023: Administrator not able to delete user notifications

buddypress-trac noreply at wordpress.org
Mon May 16 17:17:23 UTC 2016


#7023: Administrator not able to delete user notifications
---------------------------------------+--------------------
 Reporter:  VibeThemes                 |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  2.6
Component:  Component - Notifications  |     Version:  2.5.0
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |
---------------------------------------+--------------------

Comment (by r-a-y):

 > Comments: There's an errant backslash opening line 626 of bp-
 notifications-template.php.

 Nice catch!

 > For my own education, can you say why you chose this pattern

 Since we're adding a new parameter with a default value, we can do a
 strict type check for the default value, so `0 === $user_id` is going to
 be faster.

 `if ( $user_id )` will look for non-falsey values.  Micro-optimization
 FTW!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7023#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list