[buddypress-trac] [BuddyPress Trac] #6308: bp_settings_action_general() could be broken down into smaller functions

[buddypress-trac]

#6308: bp_settings_action_general() could be broken down into smaller functions
----------------------------------+-----------------------------
 Reporter:  henry.wright          |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  normal                |   Milestone:  Future Release
Component:  Component - Settings  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  good-first-bug        |
----------------------------------+-----------------------------

Comment (by needle):

 I'm looking at this ticket because I have a need to enforce strong
 passwords across WordPress and BuddyPress and there's no filter available
 in `bp_settings_action_general()` to add additional checks to the password
 submitted via the Profile Settings form. The structure of the function
 doesn't seem to lend itself to an effective filter since the feedback
 message `switch` statement would apparently require a second one.
 Refactoring the function seems to me the logical answer to this.

 The question I have is about this ticket is what the preferred approach
 would be - i.e. would it be preferable to hook new functions to the
 `bp_actions` hook or create subroutines for the existing function?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6308#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac