[buddypress-trac] [BuddyPress Trac] #6959: Use is_default_field() everywhere instead of comparing to 1

[buddypress-trac]

#6959: Use is_default_field() everywhere instead of comparing to 1
------------------------------------------------+-----------------------
 Reporter:  slaFFik                             |       Owner:  slaFFik
     Type:  task                                |      Status:  assigned
 Priority:  normal                              |   Milestone:  2.6
Component:  Component - XProfile                |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  dev-feedback has-patch 2nd-opinion  |
------------------------------------------------+-----------------------
Changes (by slaFFik):

 * keywords:   => dev-feedback has-patch 2nd-opinion
 * component:  Component - Activity => Component - XProfile


Comment:

 There are some places, like
 `xprofile_clear_fullname_cache_on_profile_field_edit()`, where we need to
 stuck with `1`, because there is a hard-coded reference to a `fullname`
 field value. So it's not a general use default field.
 Other proposed changes are in a patch.

 But after creating a patch I got the idea, that we actually have
 `can_delete` & `is_required` separately, so it's already possible to fine-
 tune fields behaviour. So right now I'm not 100% sure that this patch
 change is required.

 Please, advise.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6959#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac