[buddypress-trac] [BuddyPress Trac] #6936: Buddypress 2.5.0 Problem when setting up email templates: Situation list blank

[buddypress-trac]

#6936: Buddypress 2.5.0 Problem when setting up email templates: Situation list
blank
--------------------------+--------------------
 Reporter:  markob17      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.5.1
Component:  API - Emails  |     Version:  2.5.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => has-patch
 * milestone:  2.5.2 => 2.5.1


Comment:

 I've confirmed that @chherbst has identified the problem and suggested the
 correct fix.

 The underlying issue is that `wp_set_post_terms()` returns term taxonomy
 IDs, not term IDs. WP's internal documentation here is incorrect:
 https://core.trac.wordpress.org/ticket/36182 Generally, `term_id` and
 `term_taxonomy_id` will be the same for newly created terms like these,
 but not when the database still contains shared taxonomy terms.

 [attachment:6936.diff] contains chherbst's fix, along with a unit test
 that demonstrates the fix. In order to make testing easier, I broke the
 email and email-type definitions into standalone functions. @DJPaul I'd
 like your feedback on whether that's OK, and whether you have better ideas
 for function names.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6936#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac