[buddypress-trac] [BuddyPress Trac] #7114: XProfile: Do not duplicate populate logic in BP_XProfile_Field

buddypress-trac noreply at wordpress.org
Wed Jul 20 17:51:03 UTC 2016


#7114: XProfile: Do not duplicate populate logic in BP_XProfile_Field
------------------------------+---------------------
 Reporter:  r-a-y             |       Owner:  r-a-y
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  2.7
Component:  Extended Profile  |     Version:  2.4.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10948"]:
 {{{
 #!CommitTicketReference repository="" revision="10948"
 XProfile: Do not duplicate populate logic in the `BP_XProfile_Field`
 class.

 Previously, the `$wpdb->get_row()` call was duplicated in both the
 `BP_XProfile_Field::populate()` and `BP_XProfile_Field::get_instance()` DB
 methods.

 This commit merges the logic into the `BP_XProfile_Field::populate()`
 method and passes existing unit tests.

 Fixes #7114.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7114#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list