[buddypress-trac] [BuddyPress Trac] #6482: Comment syncing between activity and post comments for Custom Post Types

[buddypress-trac]

#6482: Comment syncing between activity and post comments for Custom Post Types
--------------------------------------------------+-----------------------
 Reporter:  shanebp                               |       Owner:  imath
     Type:  enhancement                           |      Status:  assigned
 Priority:  normal                                |   Milestone:  2.5
Component:  Component - Blogs                     |     Version:  2.2
 Severity:  normal                                |  Resolution:
 Keywords:  needs-testing dev-feedback has-patch  |
--------------------------------------------------+-----------------------

Comment (by imath):

 Many thanks for this new feedback and the chat we had on slack about it
 yesterday night r-a-y :)

 I'm feeling a lot better with `bp_activity_type_supports()` now we're
 prefixing the post type activities specific features with a 'post-type'
 term.

 I've updated the patch so it now uses this very promising new function :)
 In .05.patch i'm also including a 'comment-reply' feature check for any
 activity. We can do this from now on because we have a complete perimeter
 for post type activities (generate activity on when a post type is
 published / a Comment about this post type is validated / Comments between
 the Activity object and the Post Type object are synchronized). As a
 result the `bp_activity_can_comment()` function is now looking nicer. But
 as i've played in this area i also added 2 new unit tests about it.

 I've tested it, and everything seems to work fine.

 I'm feeling really confident about splitting/committing this .05.patch
 really soon :)

 Does anyone have any objection ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6482#comment:27>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac