[buddypress-trac] [BuddyPress Trac] #4062: Activity makes profile avtivity filtered aswel

[buddypress-trac]

#4062: Activity makes profile avtivity filtered aswel
-------------------------------------+------------------
 Reporter:  gogger                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.8
Component:  Activity                 |     Version:  1.2
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch dev-feedback => has-patch needs-testing


Comment:

 @lakrisgubben Thanks so much for working on this ticket (and sorry for the
 delay in review!).

 In some ideal world, it'd be nice if we had more fine-grained logic for
 setting the current filter based on context and cookie. I mean, what's the
 value in sharing the cookie between the global activity stream and a group
 activity stream, even when the filter is valid in both contexts? If I had
 my druthers, I'd yank out the entire set-filter-based-on-cookie system
 altogether - it causes more problems than it solves.

 Given the state of things, I think the approach in your patch is
 appropriate. In [attachment:4062.2.diff], I've taken up your suggestion to
 break the shared logic into a new function. Two, actually: one to get the
 "current context", and one to return a list of valid actions for a given
 context. It seems to me that having this level of granularity in the
 functions will allow devs to do interesting things in the future.

 Anyway, would you have a look to see if it's close to what you had in
 mind, and to be sure that I haven't butchered the fix itself?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4062#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac