[buddypress-trac] [BuddyPress Trac] #7386: BP_Group_Extension: Create screen is not passed the new group ID.

buddypress-trac noreply at wordpress.org
Tue Dec 20 15:12:49 UTC 2016

#7386: BP_Group_Extension: Create screen is not passed the new group ID.
 Reporter:  dcavins           |       Owner:  boonebgorges
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  2.8
Component:  Groups            |     Version:  2.7.2
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |

Comment (by dcavins):

 Replying to [comment:5 boonebgorges]:
 > > I'm sort of in favor of doing a more wholesale strip of the oddly
 isolated groups_action_create_group(). Now that you've moved some logic
 into setup_globals(), moving more of the create screen setup into that
 method would make the create screens seem more like a part of the groups
 > I agree - this would be a worthwhile thing to pursue, as it would make
 the internals of the Groups component more consistent and easier to debug.
 But it also has the potential to introduce bugs, so it should be pursued
 with more caution than we need to make this minor fix. So let's handle it

 Sounds good to me. I'm trying to see what parts of the group creation
 process we can write tests for, so we can make changes with some
 confidence, otherwise we'll be back to guessing how we might affect other
 plugins and the creation process generally.

 Thanks for making this commit, which fixes this immediate problem in a
 less hack-ish way than my suggested fix.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7386#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list