[buddypress-trac] [BuddyPress Trac] #7374: Add new filter to bp_activity_do_heartbeat()

buddypress-trac noreply at wordpress.org
Thu Dec 15 18:36:26 UTC 2016

#7374: Add new filter to bp_activity_do_heartbeat()
 Reporter:  wordpressrene                    |       Owner:  boonebgorges
     Type:  enhancement                      |      Status:  assigned
 Priority:  normal                           |   Milestone:  2.8
Component:  Activity                         |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => assigned


 Replying to [comment:5 wordpressrene]:
 > I will correct the code.
 > I don't know if somebody, who hasn't activated the heartbeat refresh
 needs to have the filter when returning early. In addition to this you can
 filter the return value of `bp_is_activity_heartbeat_active()` to prevent
 returning early. So I think we don't need to add the filter here. What do
 you think @boonebgorges?

 I agree it's unlikely that the filter would be useful in this case, but
 for consistency's sake, I think it makes sense for the return value always
 to be filtered. Thanks for the patch!

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7374#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list