[buddypress-trac] [BuddyPress Trac] #7371: No action for group photo upload?

buddypress-trac noreply at wordpress.org
Tue Dec 6 18:32:03 UTC 2016

#7371: No action for group photo upload?
 Reporter:  bhargavbhandari90                    |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  2.8
Component:  Groups                               |     Version:  2.7.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |

Comment (by bhargavbhandari90):

 Replying to [comment:4 boonebgorges]:
 > Thanks for the patch, @bhargavbhandari90. A few comments:
 > - I agree that it would be good to send the whole array to the action.
 However, we can't change the existing parameters sent to the action, as
 this change will break existing uses. We could add the whole array as a
 new parameter.\
 > - The new action appears in two places:
 `groups_screen_group_admin_avatar()` and `bp_avatar_ajax_set()`. The
 parameters passed to the function must be the same (or at least
 compatible) in each of these places.
 > - The name 'xgroup_avatar_uploaded' doesn't match our naming
 conventions. 'xprofile' is short for 'Extended Profile'. I'd prefer
 somethting like 'bp_groups_uploaded_avatar', but this is fairly different
 from 'xprofile_avatar_uploaded', so I feel like we should just go with

 Ok. Agree with you. So for action name I'll go with the name

 And I added that third parameter which will be array as I said before. I
 checked that and will not make harm to existing users.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7371#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list