[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type

[buddypress-trac]

#7226: Update BP_buttons class to accept new arg param for $element_type
-------------------------+------------------
 Reporter:  hnla         |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.7
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by r-a-y):

 > Backpat link_* atts work as I didn't update Nouveau for those. Class
 doesn't seem to be passing through as an array key/value pair of
 'button_attr' but that might be something on my end.

 If you're using a deprecated `link_*` parameter, this will take precedence
 instead of `button_attr['class']`.  So I'm guessing you have `link_class`
 set?

 > We ought to get data-*="" rendering if possible.

 I was thinking about this some more.

 Would it be clearer just to set up data attributes individually in
 `button_attr` instead?

 {{{#!php
 array(
     'button_attr' => array(
         'class' => 'my-css-class',
         'data-whatever' => 'my custom data',
         'data-foobar' => 'foo'
     ),
 )
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:21>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac