[buddypress-trac] [BuddyPress Trac] #6060: Display and filter by member type on Dashboard > Users

[buddypress-trac]

#6060: Display and filter by member type on Dashboard > Users
--------------------------------------+-----------------------
 Reporter:  boonebgorges              |       Owner:  slaFFik
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  2.7
Component:  Members                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |
--------------------------------------+-----------------------

Comment (by dcavins):

 Hi @slaFFik, this is really good. I've tested your new patch this morning
 and have a few comments:
 * The function `users_type_change_to()` relies on a passed parameter
 `$which` to know whether the control is above or below the table. This
 parameter wasn't passed to the action hook until WP 4.6, so in 4.5 and
 earlier, the upper dropdown's input never works (it has the same `name` as
 the lower, so it's overwritten in the `$_REQUEST`). Is there anything we
 can do to make this work in 4.5 and earlier? Short of a global variable,
 I'm not sure how to output the control only once in earlier versions.
 * The "Change" button uses a duplicated `id`. This is the behavior of the
 "Change Role" control, too, but I'd still like to avoid it.
 * I like the way you've handled filtering by type (using the type column
 output as filter links). This is a nice, unobtrusive touch.
 * It would be cool if the Member Type column were sortable, but that could
 be a future improvement.

 Updates I've made in the patch I'll add:
 * Use the `$id_name` variable in the label in `users_type_change_to()`
 * Change the foreach behavior so that all member changes are made before
 redirecting in `users_type_bulk_change()`.

 Thanks for the cool stuff!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6060#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac