[buddypress-trac] [BuddyPress Trac] #3961: Hierarchical groups

buddypress-trac noreply at wordpress.org
Tue Aug 9 16:34:54 UTC 2016


#3961: Hierarchical groups
------------------------------------+-----------------------
 Reporter:  sooskriszta             |       Owner:  dcavins
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.7
Component:  Groups                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by DJPaul):

 The upgrader code is all about being used once, right?
 `update_to_x_version` is only called if you're on an older version.

 The performance concern is why I said a direct SQL query to only return
 the IDs avoids any of the (unintentional) overhead of using the existing
 `groups_get_group` function*. It also avoids out-of-date cached
 information being returned, when the whole point is to clear the cache.
 It's about the only place I'd ever use a direct SQL query.

 Unless someone is going to commit to "fixing" the upgrader code in 2.7 or
 2.8 -- of which I've seen no significant interest in recently -- worrying
 about giant-scale BP sites, is beginning to feel like an edge case excuse.

 (*The function may already have great SQL for returning IDs only, and for
 forcing a query instead of using a cache. I haven't looked.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3961#comment:48>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list