[buddypress-trac] [BuddyPress Trac] #6765: Use WP page names for BP directory pages headings

buddypress-trac noreply at wordpress.org
Wed Apr 20 09:08:27 UTC 2016


#6765: Use WP page names for BP directory pages headings
-------------------------------------+------------------
 Reporter:  hnla                     |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.6
Component:  Component - Any/All      |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by imath):

 Hi @hnla

 I agree it's a good idea. But i don't think we need to use
 `bp_core_get_directory_pages()` again as the buddypress()->pages global
 set by `bp_core_set_uri_globals()` is already using this function.

 So we could probably use a patch looking like 6765-02c.patch. But if i
 look at the components loaders code it seems more consistent to do
 6765-02a.patch as that's the way we do it for directory slugs.

 6765-02c.patch seems a bit "agressive" with plugins component to me. In
 the same spirir we could also do 6765-02b.patch. Both are better for the
 user as he can set the title for any directory component and as a plugin
 developer i'd be ok with both.

 But if we only want to deal with our components and leave the choice to
 plugins authors, then 6765-02a.patch is best :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6765#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list