[buddypress-trac] [BuddyPress Trac] #6716: bp-screen-reader-text class and Themes overridding buddypress.css

[buddypress-trac]

#6716: bp-screen-reader-text class and Themes overridding buddypress.css
--------------------------------+----------------------------------
 Reporter:  imath               |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Under Consideration
Component:  API - Theme Compat  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  dev-feedback        |
--------------------------------+----------------------------------

Comment (by hnla):

 I'm inclined to close this for following reasons:

 First and foremost we are now past the danger point, if there had have
 been an issue we would have needed to deploy this by now!

 As imath says he's a bad user :) and hasn't covered the class in his
 overloaded styles, this is a common class used to hide label text, we(BP)
 have added a number of these class tokens on labels that previously didn't
 exist & the ruleset however it has always to be the responsibility of the
 custom theme to deal with ensuring any new styles, script, or markup
 additions are accounted for.

 Yes true those labels may appear, but enqueueing embedded head styles just
 to cover the possibility of a few custom themes having an issue? We're
 loading styles on every page, that won't cache just to prevent labels
 showing for a few themes do we want to do that? If we did perhaps we
 should load only if we detect overloaded theme?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6716#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac