[buddypress-trac] [BuddyPress Trac] #6675: WP 4.4 deprecates wp_title()

[buddypress-trac]

#6675: WP 4.4 deprecates  wp_title()
------------------------------+------------------
 Reporter:  mercime           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.4
Component:  Component - Core  |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by imath):

 6675.02.patch is improving 6675.patch by:

 - making sure to choose the right filter once the theme is set up.
 - removing the `Page [Activity ID]` as i agree with slaFFIik, an activity
 ID is not a page and there's no reason to have this part in the title.

 I've tested 6675.02.patch from WordPress 3.8 to trunk and it's working
 fine on each version with themes supporting or not the `title-tag`

 When a theme is not supporting the `title-tag` it's important to note that
 BuddyPress '''can't''' do anything about the notice error. It's theme's
 responsibility to use the WordPress way of generating the title tag as
 explained in the [https://make.wordpress.org/core/2015/10/20/document-
 title-in-4-4/ make article] :
 > This latest change makes the new API (almost) feature complete and theme
 authors are discouraged from using wp_title() in the future

 It's also important to note that even if the theme is still using
 `wp_title()` the patch makes sure the title of the BuddyPress pages are
 still built the right way.

 Finally, with this patch applied and with WordPress 4.4, it's also
 important to know that we could have a case where the active theme
 supports the `title-tag` and the site's administrator has activated a
 breadcrumb plugin still using the `wp_title()` function in this case the
 breadcrumb would get a notice error and a null value as the page title. If
 the breadcrumb is using `wp_get_document_title()` then it will get no
 notice error and the BuddyPress page title.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6675#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac