[buddypress-trac] [BuddyPress Trac] #6388: Groups single item home : improve the way we deal with custom front and activity component

[buddypress-trac]

#6388: Groups single item home : improve the way we deal with custom front and
activity component
-----------------------------------------+---------------------
 Reporter:  imath                        |       Owner:  imath
     Type:  defect (bug)                 |      Status:  closed
 Priority:  normal                       |   Milestone:  2.4
Component:  Component - Groups           |     Version:
 Severity:  normal                       |  Resolution:  fixed
 Keywords:  has-patch needs-docs commit  |
-----------------------------------------+---------------------
Changes (by imath):

 * owner:   => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10184"]:
 {{{
 #!CommitTicketReference repository="" revision="10184"
 Improve template loading for Groups single items home pages.

 - Make sure an activity sub navigation will be generated if the displayed
 group has a custom front page.
 - Make sure no members sub navigation is generated if the activity
 component is not active and the Group has no custom front. As, in this
 case the home page of the group is already displaying the members
 template.
 - Make sure some Groups single item conditional tags are behaving the
 right way:
  - `bp_is_group_home()` is true when on the home page of the group (eg:
 site.url/groups/single-group/).
  - `bp_is_group_activity()` is true when the activity page of the group is
 displayed. It can be the home page of the group or its activity page (eg:
 site.url/groups/single-group/activity).
  - `bp_is_group_members()` is true when the members page of the group is
 displayed. It can be the home page of the group or its members page (eg:
 site.url/groups/single-group/members).
 - Introduce a new conditional tag: `bp_is_group_custom_front()` to check
 if the home page of the group is using a custom front template.
 - Introduce a new template tag `bp_groups_front_template_part()` used to
 choose the appropriate template to load for the home page of the group
 (activity, members, or the custom front).
 - Introduce a template hierarchy for the
 `buddypress/groups/single/front.php` template so that it is possible to
 have different front pages according to the ID, slug or status of the
 Group.
 - And finally make sure the introduced improvements are back compatible
 with themes who forgot to update their `buddypress/groups/single/home.php`
 and `buddypress/activity/post-form.php` templates.

 Props r-a-y, boonebgorges, DJPaul, and imath :)

 Fixes #6388
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6388#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac