[buddypress-trac] [BuddyPress Trac] #6745: AJAX pagination doesn't account for new component search parameter

[buddypress-trac]

#6745: AJAX pagination doesn't account for new component search parameter
---------------------------------+--------------------
 Reporter:  r-a-y                |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  2.4.1
Component:  Component - Any/All  |     Version:  2.4.0
 Severity:  normal               |  Resolution:
 Keywords:  has-patch            |
---------------------------------+--------------------
Description changed by r-a-y:

Old description:

> When we changed the search parameter for BuddyPress directory pages
> (#5087), we did not account for pagination.
>
> Attached patch fixes this.
>
> '''Note:''' We currently do not add the search term parameter for the
> activity or blog template loops.  We probably should do this either in
> 2.4.1 or 2.5.0.
>
> ----
>
> This bug also uncovered an error with how we parse pagination page
> numbers in AJAX since WordPress 4.1.  See #WP30831.  The problem is due
> to r7946.  (Basically, what henry.wright warned me about here -
> ticket:5404#comment:13!  Boo Ray!)
>
> The page number fix reverts what I committed in #5404 with what I
> originally recommended here:
> https://buddypress.trac.wordpress.org/attachment/ticket/5404/5404.01.2.patch
>
> I would preferably like to include this fix in 2.4.1 as well.

New description:

 Reported here:
 https://buddypress.org/support/topic/bp-2-4-breaks-on-page-2-of-custom-
 search-results/#post-247021

 When we changed the search parameter for BuddyPress directory pages
 (#5087), we did not account for pagination.

 Attached patch fixes this.

 '''Note:''' We currently do not add the search term parameter for
 pagination in the activity or blog template loops.  We probably should do
 this either in 2.4.1 or 2.5.0.

 ----

 This bug also uncovered an error with how we parse pagination page numbers
 in AJAX since WordPress 4.1.  See #WP30831.  The problem is due to r7946.
 (Basically, what henry.wright warned me about here -
 ticket:5404#comment:13!  Boo Ray!)

 The page number fix reverts what I committed in #5404 with what I
 originally recommended here:
 https://buddypress.trac.wordpress.org/attachment/ticket/5404/5404.01.2.patch

 I would preferably like to include this fix in 2.4.1 as well.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6745#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac