[buddypress-trac] [BuddyPress Trac] #6675: WP 4.4 deprecates wp_title()

[buddypress-trac]

#6675: WP 4.4 deprecates  wp_title()
------------------------------+--------------------
 Reporter:  mercime           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.4.1
Component:  Component - Core  |     Version:
 Severity:  major             |  Resolution:
 Keywords:  has-patch         |
------------------------------+--------------------

Comment (by r-a-y):

 `6675.03.patch` builds on the work imath has done, but with the following
 changes:

 - Removes the `'bp_modify_document_title'` filter and adds a
 `'bp_title_parts'` filter above the fold.  I think filtering the BP title
 parts is better as it will work for both title filters.
 - Moves the older title tag compatibility stuff into the `// 'wp-title'`
 conditional block as it is only relevant there.
 - Changed `bp_do_document_title()` to `bp_setup_document_title()` and did
 a tiny bit of refactoring.
 - I've added a `todo` note that is similar to DJPaul's concern about re-
 using the `'bp_modify_page_title'` filter in our new WP 4.4 document title
 conditional block.  The reason I did not implement it is the older
 `'bp_modify_page_title'` filter includes the sitename.  The place where I
 want to re-apply the `'bp_modify_page_title'` filter will not have the
 sitename added since WP 4.4 will automatically add it in
 `wp_get_document_title()`.  I'm not sure if we should re-use this filter.
 Need some feedback here.

 Tested with Twenty Twelve, Twenty Fifteen, Twenty Sixteen on both WP
 4.4-bleeding and WP 4.3.1.

 Let me know what you think!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6675#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac