[buddypress-trac] [BuddyPress Trac] #6462: Group invites cannot be removed anymore!

[buddypress-trac]

#6462: Group invites cannot be removed anymore!
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  regression             |      Status:  new
 Priority:  highest                |   Milestone:  2.3
Component:  API                    |     Version:
 Severity:  major                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------
Changes (by imath):

 * keywords:  needs-patch => has-patch 2nd-opinion


Comment:

 Ok i see the problem is coming from in r9810 where to uninvite a user it
 has been changed from :
 `!BP_Groups_Member::delete( $user_id, $group_id )`

 to

 `! BP_Groups_Member::delete_invite( $user_id, $group_id )`

 I understand the logic, but the problem is that
 `BP_Groups_Member::delete_invite` is checking for `invite_sent = 1` And
 when i'm changing my mind, invite is not sent yet.

 So i thought about coming back to `!BP_Groups_Member::delete( $user_id,
 $group_id )` to solve the issue (see 01.patch), but i think a better plan
 is to adapt `BP_Groups_Member::delete_invite` so that we get rid
 `invite_sent = 1` as i think the check upon `inviter_id != 0` is enough
 (see 02.patch).
 Actually i'd prefer this second option because i don't knwo if using
 `BP_Groups_Member::delete( $user_id, $group_id )` could have an impact on
 a request made by a user. It looks like today (and it was the case in 2.2)
 it's not possible to select a friend who requested to be a member of the
 group (on a side note, should be best to not display this user in the list
 of friends or display a more interesting feedback)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6462#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac