[buddypress-trac] [BuddyPress Trac] #6448: Unconditional set of $wp_rewrite->use_verbose_page_rules = false breaks flush_rewrite_rules()

[buddypress-trac]

#6448: Unconditional set of $wp_rewrite->use_verbose_page_rules = false breaks
flush_rewrite_rules()
--------------------------+-----------------------------
 Reporter:  chherbst      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  API           |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 Bp unconditionally sets $wp_rewrite->use_verbose_page_rules = false since
 this commit: https://buddypress.trac.wordpress.org/changeset/5970.

 This breaks rewrite rules written by flush_rewrite_rules() in setups were
 the post name is used for the permalink structure. This is due to line
 1609 of rewrite.php. In these setups, rewrite rules for pages should be
 written before rewrite rules for posts. Due to Bp setting
 $wp_rewrite->use_verbose_page_rules to false, it happens to be the other
 way around. The symptom of this can be a 404 error when accessing a page
 by it's permalink.
 One way to reproduce this bug involves Learndash, but it can potentially
 occur with any plugin that uses flush_rewrite_rules().

 Steps to reproduce:
 1. Fresh WordPress 4.1.1 install
 2. Install and activate the plugins BuddyPress 2.2.1 and LearnDash 2.0.6.3
 (both newest versions)
 3. open [wordpress-root]/sample-page/ -> Page is showing correctly
 4. open [wordpress-root]/activity/ and post something
 5. reload [wordpress-root]/sample-page/

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6448>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac