[buddypress-trac] [BuddyPress Trac] #6225: Naming of Body Classes: 'my-profile' & 'my-account'

buddypress-trac noreply at wordpress.org
Wed May 6 20:01:45 UTC 2015


#6225: Naming of Body Classes: 'my-profile' & 'my-account'
------------------------------+----------------------------------
 Reporter:  landwire          |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Under Consideration
Component:  Component - Core  |     Version:  1.1
 Severity:  minor             |  Resolution:
 Keywords:  dev-feedback      |
------------------------------+----------------------------------
Changes (by r-a-y):

 * keywords:  needs-patch => dev-feedback
 * version:  2.1 => 1.1
 * milestone:  2.3 => Under Consideration


Comment:

 The usage of `'my-'` as a CSS class prefix is actually wrong for the
 majority of BP's body classes.


 eg.

 {{{
 // this only checks if you're on a friends page within a user context,
 // not if you're on your own friends page...
 if ( bp_is_user_friends() ) {
         $bp_classes[] = 'my-friends';
 }
 }}}

 We could fix this by adding a new class with `'user-'` as the prefix, but
 that would just add an extra class.

 Not sure if we want to do anything here...

 Moving to the "Under Consideration" milestone.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6225#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list