[buddypress-trac] [BuddyPress Trac] #6278: Attachment Library

[buddypress-trac]

#6278: Attachment Library
------------------------------------+-----------------------
 Reporter:  imath                   |       Owner:  imath
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.3
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by imath):

 Thanks for your feedback.

 I'm planing to commit:
 1. abstract the BP_Attachment class, so it must be extended.
 2. avoid using `get_class_vars( __CLASS__ )` to get the default values in
 the BP_Attachment constructor
 3. Sanitize the base_dir if set
 4. Make sure the action and file_input parameters are also sanitized
 5. use a is_dir() check instead of a file_exists() one when checking if
 the upload_path exists
 6. Use bp_parse_args in the BP_Attachment crop method
 7. use 'elseif' instead of 'else if' use '!==' instead of '!='.

 Any objections ?

 Then i'll open a new ticket for the i18n improvements that introduces the
 need to improve `bp_core_check_avatar_type`

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6278#comment:59>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac