[buddypress-trac] [BuddyPress Trac] #2693: bp_format_time returns incorrect value when gmt_offset is empty

[buddypress-trac]

#2693: bp_format_time returns incorrect value when gmt_offset is empty
------------------------------------------+-----------------------
 Reporter:  stevejohnson                  |       Owner:
     Type:  defect (bug)                  |      Status:  reopened
 Priority:  normal                        |   Milestone:  2.3
Component:  Component - Core              |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |
------------------------------------------+-----------------------

Comment (by johnjamesjacoby):

 In [changeset:"9617"]:
 {{{
 #!CommitTicketReference repository="" revision="9617"
 Core: Update `bp_format_time`:

 * Use `bp_get_option()` over `get_blog_option()` and (incorrect)
 `get_option()` calls.
 * Rename variables for clarity, as generic date/time/offset variables were
 easy to accidentally stomp.
 * Port logic from `wp_timezone_override_offset()` and calculate timezone
 offset if `timezone_string` is set in the root blog's options.
 * Pass `$localize_time` parameter into `date_i18n()` function call, to
 ensure the most accurate results possible are returned back from
 WordPress.

 See #2693.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/2693#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac