[buddypress-trac] [BuddyPress Trac] #6218: bp_friend_get_total_requests_count() could use already cached data

[buddypress-trac]

#6218: bp_friend_get_total_requests_count() could use already cached data
--------------------------------------+------------------
 Reporter:  wpdennis                  |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  2.3
Component:  Component - Friends       |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  2nd-opinion dev-feedback  |
--------------------------------------+------------------
Changes (by Mamaduka):

 * keywords:  2nd-opinion => 2nd-opinion dev-feedback


Comment:

 Caching in `get_friendship_request_user_ids()` was introduced in r8105, as
 a part of object cache improvement for friends component.

 If we're going to deprecated one of those function, I think
 `get_friendship_request_user_ids()` should be our choice. Since
 `BP_Friends_Friendship::get_friend_user_ids()` can return same values and
 more. But this gonna make caching in later function bit complicated, where
 we should change cache group based on args.

 I would love to here hear 2nd option on this as well.

 P.S. What wpdennis suggest is pretty straightforward and happy to provide
 patch for it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6218#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac