[buddypress-trac] [BuddyPress Trac] #6517: bp_create_excerpt returning mall-formed markup - mb_strlen issues?

buddypress-trac noreply at wordpress.org
Mon Jun 22 13:18:23 UTC 2015


#6517: bp_create_excerpt returning mall-formed markup - mb_strlen issues?
------------------------------+------------------
 Reporter:  hnla              |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.4
Component:  Component - Core  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 2.4


Comment:

 Thanks for tracking this down a bit, hnla. There seem to be two problems.
 The first is that the regex change in [9523] made the tag check too
 liberal, with the result that some larger-than-desired chunks were being
 detected. The second is that the `exact=false` logic - which ensures that
 strings are only truncated on word boundaries - was not distinguishing
 between a space that is a word boundary and a space that appears inside of
 an HTML tag. That is, when truncating `Foo <a
 href="http://example.com">Bar</a> Baz` with `exact=false`, we should never
 break on the space between `a` and `href`.

 Please test [attachment:6517.diff] to see if it's solving your problems.
 Thanks!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6517#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list