[buddypress-trac] [BuddyPress Trac] #5192: User roles with differents profile fields

[buddypress-trac]

#5192: User roles with differents profile fields
----------------------------------+------------------
 Reporter:  _DorsVenabili         |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  normal                |   Milestone:  2.4
Component:  Component - XProfile  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch             |
----------------------------------+------------------

Comment (by imath):

 @boonebgorges here's my feedbacks :

 1/ thanks a lot for adding the possibility to get fields for a given
 member type even if the user_id is not set.

 2/ thanks a lot for using `member_type` instead of `member-type` for the
 `meta_key`

 3/ As discussed on
 [https://wordpress.slack.com/archives/buddypress/p1436818065001433 slack],
 the `_none` value (meaning no checkboxes are checked) should generate a
 message to inform the field won't be displayed to any member.

 4/ The base profile field `Name (primary)(required)` shouldn't have the
 metabox to set the member type, as it needs to always be output.

 5/ Thanks a lot for `BP_XProfile_Field->get_member_type_label()`, i think
 this piece of info in the list of xProfile fields is really interesting,
 but :
 - when a field concerns all member types, as it's the default value
 somehow, the list of member types labels doesn't need to be output imho.
 - in other words, maybe we should only output the labels if not all the
 checkboxes are checked.

 6/ I strongly disagree with @tanner about disabling the possibility to
 affect a member type to any field belonging to the first group of fields
 (the "registration" group of fields). As i suggest in point 4, we should
 only disable this possibility for the `Name (primary)(required)` field. I
 think it's important we leave the possibility to plugin authors to create
 multiple registration forms (eg: one by member type), which is a need
 specified as the 3rd point of this ticket's description. BTW it's pretty
 easy to achieve, now that it's possible to get fields for a given member
 type :)

 7/ When no member types are registered :
 - i think no labels should be output in the list of xProfile fields
 (`users.php?page=bp-profile-setup`) to be consistent with the fact that no
 metaboxes are displayed.
 - any field should be output no matter the value of the `member_type` into
 the database, because the member types feature is kind of inactive in this
 case.

 Thanks a lot for your great work so far :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5192#comment:43>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac