[buddypress-trac] [BuddyPress Trac] #5192: User roles with differents profile fields

buddypress-trac noreply at wordpress.org
Sat Jul 11 10:35:28 UTC 2015


#5192: User roles with differents profile fields
----------------------------------+------------------
 Reporter:  _DorsVenabili         |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  normal                |   Milestone:  2.4
Component:  Component - XProfile  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch             |
----------------------------------+------------------

Comment (by Offereins):

 Great job, Boone! For this moment I have the following feedback:

 * The field groups were already talked about, so I'm really okay to leave
 them out for this one.
 * I find it to be a clever move, using the `array( '_none' )` versus the
 empty `array()` approach, considering using the default get/set methods
 should be sufficient for using the feature. This removes the need for an
 upgrade procedure. Yet, I have two things to note here:
  * Related to @imath's profile queries, I'm not too sure how this impacts
 using `BP_XProfile_Query` when using it with a/multiple user id(s) or a
 member_type query arg.
  * One thing that may confuse devs at first, is that the
 'bp_xprofile_field_member_types' filter may contain `'_none'` and
 `'none'`, both not real member types.
 * UI-wise, I think this is a very natural approach. Feels real nice!
 * I'm really pleased with copying the i18n text-domain from my plugin :)

 Questions:
 * Should we disallow registration of member types with the `'_none'` or
 `'none'` key?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5192#comment:36>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list