[buddypress-trac] [BuddyPress Trac] #6545: Provide new XProfile field object with WPDB's insert_id

[buddypress-trac]

#6545: Provide new XProfile field object with WPDB's insert_id
----------------------------------+---------------------------
 Reporter:  Offereins             |       Owner:  boonebgorges
     Type:  defect (bug)          |      Status:  closed
 Priority:  normal                |   Milestone:  2.4
Component:  Component - XProfile  |     Version:
 Severity:  normal                |  Resolution:  fixed
 Keywords:                        |
----------------------------------+---------------------------

Comment (by Offereins):

 Replying to [comment:1 boonebgorges]:
 > Thanks for the patch. Unfortunately, this change by itself won't work,
 as there are a number of other `empty( $this->id )` checks in the method.

 While this is true, the second empty-check results in the same: it uses
 either `$this->id` or `$wpdb->insert_id`. This check would become
 redundant since it just means `$parent_id = $this->id`. Am I right? Less
 is more :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6545#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac