[buddypress-trac] [BuddyPress Trac] #6176: Cannot save 'register' and 'activate' pages when sign-ups are off

[buddypress-trac]

#6176: Cannot save 'register' and 'activate' pages when sign-ups are off
-------------------------------------+------------------
 Reporter:  johnjamesjacoby          |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.3
Component:  Sign ups & Activation    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  2nd-opinion needs-patch  |
-------------------------------------+------------------
Description changed by johnjamesjacoby:

Old description:

> If user sign-ups are turned off, the UI for saving Register and Activate
> pages exists, but their values do not save, nor do the pages themselves
> render as part of theme compatibility.
>
> I haven't checked this configuration in a while, but this seems like a
> regression to me, like it used to work differently.
>
> If sign-ups were once turned on and a page was created and assigned, and
> then later sign-ups are turned off, that page and association still
> exist, and we should show a "Sorry, sign-ups are currently disabled" type
> message instead of a page.
>
> We could also hide the page assignment UI if `bp_get_signup_allowed()`
> returns false, but that leaves options in the database with no ability to
> modify them. Users should be able to modify slugs & page-assignments for
> these two pages, and they should never not act like sign-up and
> activation pages.

New description:

 If user sign-ups are turned off, the UI for saving Register and Activate
 pages exists, but their values do not save, nor do the pages themselves
 render as part of theme compatibility.

 I haven't checked this configuration in a while, but this seems like a
 regression to me, like it used to work differently.

 If sign-ups were once turned on and a page was created and assigned, and
 then later sign-ups are turned off, that page and association still exist,
 and we should show a "Sorry, sign-ups are currently disabled" type message
 instead of a page.

 We could also hide the page assignment UI if `bp_get_signup_allowed()`
 returns false, but that leaves options in the database with no ability to
 modify them. Users should be able to modify slugs & page-assignments for
 these two pages, and they should never not act like sign-up and activation
 pages when they are assigned.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6176#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac