[buddypress-trac] [BuddyPress Trac] #5817: Additional styling support for BuddyPress Widgets

[buddypress-trac]

#5817: Additional styling support for BuddyPress Widgets
----------------------------------------+------------------
 Reporter:  mercime                     |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  2.2
Component:  Theme / Template Parts      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |
----------------------------------------+------------------

Comment (by mercime):

 Patches to make sure that the required classes used in buddypress.css are
 present in the markup of any theme's sidebar widget.

 5817-4a.diff attached
 * Targets BP widgets only
 * Inserts a new div with required classes "widget buddypress" within
 existing widget container
 * Removes possibility of duplicating .widget padding or margin which might
 have been added to the original .widget container

 5817-4b.diff attached
 * Targets BP widgets only
 * Inserts required classes "widget buddypress" before other classes

 Having done the above, I agree with @ray that "that the themes that are
 doing-it-wrong should fix up their widget sidebar calls". Which is why: 1)
 a. I also posted a note for the theme author at
 https://themes.trac.wordpress.org/ticket/11170#comment:3 to consider
 making the changes in his theme even if the last theme update was 2 years
 ago; and 2) I did not include any support for themes which did not add the
 class attribute in their theme's $before_widget

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5817#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac