[buddypress-trac] [BuddyPress Trac] #6099: groups/favorites/friends activity scopes when displayed user has not any 'scope' items

[buddypress-trac]

#6099: groups/favorites/friends activity scopes when displayed user has not any
'scope' items
--------------------------+-----------------------------------
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  high          |  Milestone:  2.2
Component:  Activity      |    Version:
 Severity:  major         |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 We have a trouble in adjusting scopes for
 {{{BP_Activity_Activity::get_scope_query_sql}}} when the displayed user
 does not have any items in the active scope. In this case '''all''' user's
 activities are fetched instead of none.

 Way to reproduce for the {{{favorites}}} scope for instance : simply make
 sure the displayed user has not favorited any items.

 I've built unit tests and realized it's also appearing on groups and
 friends scopes.

 To solve this i suggest to set dummy arrays having a {{{0}}} value as the
 item id when the user is not a part of any groups/did not favorited any
 activities or has no friends.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6099>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac