[buddypress-trac] [BuddyPress Trac] #6090: Fix groups_join_group() & groups_accept_invite() behavior

[buddypress-trac]

#6090: Fix groups_join_group() & groups_accept_invite() behavior
------------------------------+------------------
 Reporter:  dcavins           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.2
Component:  Groups            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------

Comment (by dcavins):

 Replying to [comment:1 r-a-y]:
 Thanks for looking over the patch r-a-y.

 I'm a bit worried about the use of `BP_Groups_Member::delete` in
 `groups_delete_membership_request()` because that will delete any record
 that involves the user and group, which could include any requests,
 invitations or memberships, right? In these functions, it follows the
 deletion of invitations while the group membership is being created, so I
 guess those other possible records are also being deleted. It's also used
 in `groups_reject_membership_request()` so it could potentially delete
 invitations as well as requests there.

 Short of using `delete_request()`, I'm not sure how to prevent the
 function from being overzealous.

 Is this worth deprecating the current function and switching over to a new
 function?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6090#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac