[buddypress-trac] [BuddyPress Trac] #6173: 'Members' menu selected when current page user profile page

[buddypress-trac]

#6173: 'Members' menu selected when current page user profile page
------------------------------+------------------------------
 Reporter:  kaffeeguru        |       Owner:  johnjamesjacoby
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  2.2.1
Component:  Component - Core  |     Version:  2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------
Changes (by r-a-y):

 * keywords:  needs-testing => has-patch


Comment:

 This is kind of expected behavior.

 We've been highlighting the directory page even when on a single item page
 since v1.5.  I originally sought not to do this in r8821.

 But then, the issue came about that we wanted to keep backward
 compatibility, see:
 https://buddypress.trac.wordpress.org/ticket/5810#comment:2

 If we're okay with not highlighting the directory page when on a single
 page, then `01.patch` is an attempt to fix this.  Instead of adding the
 `current_page_item` CSS class, it adds the `current_page_parent` CSS
 class, which is more conventional to WP.

 If we want to do a hack to keep directory pages highlighted while on a
 single page, but not highlighted when we're using a BP nav menu member
 page item, then we'll need to approach this another way.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6173#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac