[buddypress-trac] [BuddyPress Trac] #6291: Companion stylesheet task - twentyfifteen

buddypress-trac noreply at wordpress.org
Sun Apr 5 11:24:36 UTC 2015


#6291: Companion stylesheet task - twentyfifteen
-------------------------+-----------------------
 Reporter:  hnla         |       Owner:  hnla
     Type:  enhancement  |      Status:  assigned
 Priority:  high         |   Milestone:  2.3
Component:  Appearance   |     Version:
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by DJPaul):

 Copying netweb's recent comments from Slack here so they aren't lost:

 {{{
 Bit more feedback on the latest patch twentyfifteen-comp-style.03.patch in
 #6291

 * There is still some trailing whitespace at the end of lines
 * Tabbed indentation is still off in some places
 * Lines #182-183, #193, #489-498: commented out code should not be
 included, if it is there for a "future" iteration then add a comment
 explaining the reason it remains commented out
 * Comments should be formatted per
 https://make.wordpress.org/core/handbook/coding-standards/css/#commenting
 * Common spacing between parentheses, various instances of both
 `(something)` and `( something )`, the later is what they all should be
 * Files should have a blank new line at the end of the file
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6291#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list