[buddypress-trac] [BuddyPress Trac] #3794: Deleted activity items remain favourited

[buddypress-trac]

#3794: Deleted activity items remain favourited
--------------------------+--------------------
 Reporter:  ewebber       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.2
Component:  Activity      |     Version:  1.5.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by imath):

 Replying to [comment:18 DJPaul]:
 > > If i have a user meta set to 3, and any random activity is deleted,
 then we would need to do another query to look for each user who favorited
 the activity and update the count for each user
 >
 > I don't think this is a blocker problem. We couldn't do this before
 because each user's list of favourites topics was stored in the
 `bp_favorite_activities` usermeta (a serialized array); the proposed
 solution lets us do this now.

 I trust you :)
 To be completely sure, maybe we could compare what's best in terms of
 query performance between calculating the number of favorites querying the
 user's 'activity_favorite' type VS using a usermeta for the count and
 making sure once an activity is deleted, get all user_ids for the
 'activity_favorite' type having the activity item_id that was deleted an
 update each found user's meta. (< i'm not sure i'm clear, sorry for my
 english)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3794#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac