[buddypress-trac] [BuddyPress Trac] #3794: Deleted activity items remain favourited

[buddypress-trac]

#3794: Deleted activity items remain favourited
--------------------------+--------------------
 Reporter:  ewebber       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.2
Component:  Activity      |     Version:  1.5.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by boonebgorges):

 3794.02.patch is great, and does cover the original issue described by the
 OP, but we really need broad unit test coverage of activity favoriting
 before doing this kind of refactoring. Please review existing favoriting-
 related functions (like `bp_activity_add_user_favorite()`) to ensure that
 there is fairly complete coverage - these are the most important parts to
 have unit tests for, as they're the ones that will cause backward
 compatibility. Would also be nice to see tests for the new functions
 you're introducing: `bp_activity_add_favorite()` etc and ideally the
 migration function too.

 Thanks for your work on this!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3794#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac