[buddypress-trac] [BuddyPress Trac] #5889: JS in bp_core_register_common_scripts() needs to be enqueued

buddypress-trac noreply at wordpress.org
Mon Sep 22 18:25:07 UTC 2014


#5889: JS in bp_core_register_common_scripts() needs to be enqueued
------------------------------+--------------------
 Reporter:  r-a-y             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.1.1
Component:  Theme             |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+--------------------

Comment (by r-a-y):

 > Yep, add scroll-to and this should all be resolved.

 I've [https://github.com/buddypress/BP-
 Default/commit/619efe8527847266c961fa43775eade42c7ff70d added the fix] on
 the bp-default Github repo.

 I enqueued the scrollTo script only on activity pages, since this is only
 used on those pages.

 > It's pretty obvious that I neglected to test properly with BP-Default,
 and that no-one else really did during beta, otherwise we'd likely have
 caught this. Lesson learnt for the future. :)

 Yeah, I forgot to test bp-default as well! :(

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5889#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list