[buddypress-trac] [BuddyPress Trac] #5919: Xprofile field meta values not deleted with field

[buddypress-trac]

#5919: Xprofile field meta values not deleted with field
--------------------------+------------------
 Reporter:  tometzky      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  2.2
Component:  XProfile      |     Version:  2.1
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------

Comment (by tometzky):

 OK. It looks that it would work. Though I'd definitely use a variable
 instead of repeating '__QUOTE__' and use `strlen($quote)` instead of `9`.

 But I'm still not convinced that this is all worth it. This was to avoid
 copying similar code from `*_meta` core functions, but:
 - it isn't any simpler;
 - it also repeats code - code in `bp-core/bp-core-filters.php` is copied
 to/from `bp-xprofile/bp-xprofile-filters.php`;
 - simply using `$wpdb->update()` did not use significantly more code;
 - it does not need to use Object Cache, as I don't see where it could be
 retrieved more than once per request anyway - so caching it just wastes
 memory; throwing out caching would simplify it even further.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5919#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac