[buddypress-trac] [BuddyPress Trac] #5193: More hooks, more power! (in the messages component)

buddypress-trac noreply at wordpress.org
Fri Nov 21 22:54:55 UTC 2014


#5193: More hooks, more power! (in the messages component)
------------------------------------+------------------
 Reporter:  slaFFik                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.2
Component:  Messaging               |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by slaFFik):

 Replying to [comment:8 boonebgorges]:
 > contains a lot of whitespace changes,

 According to WordPress Coding Standards.

 > and a couple functionality changes (like the reorganization of logic in
 `get_total_threads_for_user()`).

 Yeah, because of new ability to filter `$box` in all places.

 > Could we get separate patches for these latter things?

 So you want to split whitespaces/phpdoc changes and that function
 refactoring from the one patch? So there should be like 3 patches:
 1. whitespaces/phpdoc
 1. function refactoring
 1. actions/filters
 Am I right?

 > Ideally, any refactoring would be accompanied by unit tests.
 That will be a pain :(

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5193#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list