[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages

[buddypress-trac]

#6005: No-js bulk deletion of messages
--------------------------+------------------------------
 Reporter:  lakrisgubben  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Messaging     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by boonebgorges):

 Awesome - thanks for the patch.

 > I've made use of, and altered a bit, the function
 messages_action_bulk_delete(). I couldn't find any place in BP where this
 function is used, but tried to make sure that it would work as expected if
 used with it's old values... Any feedback on this would be greatly
 appreciated though.

 I think it's used as the AJAX callback for the JS bulk delete (though this
 could use some testing). I guess it's probably fine to reuse it, but if
 so, we'd need some unit tests first to verify that we're not breaking the
 existing functionality. (Looks like you've covered it, but the unit tests
 will increase my confidence.)

 The use of the "Delete Selected" link is in keeping with the current JS
 implementation of bulk deletion, but I wonder if we might be a bit bolder
 here: maybe this is an opportunity to bring this interface in line with
 the (IMO far superior) notifications interface. That'd mean:

 - adding a th row at the top, which would include column headers as well
 as a "Select all" checkbox
 - adding a "Bulk Actions" dropdown to the bottom of the list (alongside
 "Select")
 - in "Bulk Actions", have "Delete" in addition to "Mark Read" and "Mark
 Unread"

 So this ends up being a somewhat more significant overhaul of the
 functionality. What do you think of this? If you like the idea, I might
 ping one or two more people who have thought a lot about messages in the
 past, to get their feedback.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac