[buddypress-trac] [BuddyPress Trac] #5934: Enabling suggestions for @-mentions in groups component

buddypress-trac noreply at wordpress.org
Sat Nov 8 06:21:29 UTC 2014


#5934: Enabling suggestions for @-mentions in groups component
-------------------------+------------------
 Reporter:  m@…          |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by DJPaul):

 I didn't say that I thought it was a bad idea to add support for the Group
 Activity Stream, only the legacy Group Forums. I think I thought the
 `bp_is_activity_component` check would also work on the Group Activity
 screen.

 At any rate, the checks in `bp_activity_maybe_load_mentions_scripts` are
 meant to be as specific as possible as this function is called on every
 page load. There's a lot of screens in Groups that have nothing to do with
 composing a new activity item, so instead of using
 `bp_is_groups_component`, I'd suggest using `bp_is_group_activity` and (if
 we have to) also `bp_is_group_forum_topic_edit`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5934#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list