[buddypress-trac] [BuddyPress Trac] #5979: `bp_core_userdata_` cache is unnecessary

[buddypress-trac]

#5979: `bp_core_userdata_` cache is unnecessary
-----------------------------+------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  high             |   Milestone:  2.2
Component:  Members          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------

Comment (by djpaul):

 In [changeset:"9119"]:
 {{{
 #!CommitTicketReference repository="" revision="9119"
 Core: partial revert of r9116 (user->id to user->ID changes).

 In our legacy user fetching functions, we use something similar to "select
 ... ID as id" in the SQL. In the reverted changes, we are only using the
 property to return an array of integers, and the change of the property
 name was causing PHP to throw "undefined property" messages.

 As these lines would have never thrown a WordPress core deprecated warning
 about using `id` instead of `ID`, I'm changing them back to clear the
 warning message and fix the unit tests.

 See #5979
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5979#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac