[buddypress-trac] [BuddyPress Trac] #5565: BuddyPress 2.0 + P2 = broken mentions and notifications

[buddypress-trac]

#5565: BuddyPress 2.0 + P2 = broken mentions and notifications
---------------------------+------------------------------
 Reporter:  careb          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Activity       |     Version:  2.0
 Severity:  normal         |  Resolution:
 Keywords:  needs-testing  |
---------------------------+------------------------------
Changes (by careb):

 * keywords:  reporter-feedback needs-testing => needs-testing


Comment:

 i set up a fresh install of WordPress 3.8.1, P2 1.5.3, and BuddyPress
 2.0.1. no other plugins are activated. i have the same bug.

 you can see it here: http://teambox.calebx.com/ (username: sockx;
 password: peach)

 r-a-y - yes, i used your suggestion at the top of this ticket
 {{{
 remove_filter( 'the_content', 'bp_activity_at_name_filter' );
 }}}

 but this filter also disables email notifications. notifications aren't
 something we can go without.

 at first it looks just cosmetic, and only happens when the page is
 rendered, but each time the bug shows mentions get messed up and email
 notifications do not go out for anyone in the list of mentions--even those
 at the beginning of the list whose names are not mangled.

 i've done more digging and P2 and BuddyPress 2.0+ are using preg_replace
 to rebuild the mentions. this goes back to the patch in
 [4680](https://buddypress.trac.wordpress.org/ticket/4680) .

 P2 has a mentions.php and from line 25:

 {{{
 // Hooks
 add_action( 'init',              array( &$this, 'init'            ), 0 );
 add_filter( 'the_content',       array( &$this, 'mention_links'   ), 5 );
 add_filter( 'comment_text',      array( &$this, 'mention_links'   ), 5 );
 add_filter( 'p2_found_mentions', array( &$this, 'filter_mentions' ), 5 );
 }}}

 i've managed to workaround the but in 2.0.1 again with this change:

 {{{
 // Hooks
 add_action( 'init',              array( &$this, 'init'            ), 0 );
 add_filter( 'the_content',       array( &$this, 'mention_links'   ), 20 );
 add_filter( 'comment_text',      array( &$this, 'mention_links'   ), 20 );
 add_filter( 'p2_found_mentions', array( &$this, 'filter_mentions' ), 20 );
 }}}

 this corrects the bug in posts but not in comments. comments are still
 producing the bug ...

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5565#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac