[buddypress-trac] [BuddyPress Trac] #5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns

[buddypress-trac]

#5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns
-------------------------+-----------------------------------
 Reporter:  imath        |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  2.1
Component:  Activity     |    Version:  2.0
 Severity:  normal       |   Keywords:  has-patch 2nd-opinion
-------------------------+-----------------------------------
 {{{bp_activity_set_action()}}} is used to register the activity actions.

 This helps building the drop down types in Activity Administration and
 registering the callable functions that will dynamically generate the
 translatable action strings.

 But in bp-templates :
 - activity/index.php
 - members/single/activity.php
 - groups/single/activity.php

 the filters are directly built in it. I've seen that in 2.0 , to avoid
 backcompat theme issues the 'Profile Updates' type was introduced using
 one of the templates hook to add a new activity type into the drop down
 ({{{'bp_activity_filter_options'}}}).

 I think we can improve this by using bp_activity_set_action() to also set
 the different template dropdowns options. This way we would (and plugins)
 only need to use this function to feed admin and front drop downs.

 It would also avoid the different bp_is_active() checks in templates.
 Finally i think it won't have any impact on theme backcompat.

 So i suggest the patch attached to this ticket.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5637>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac